Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix multi-operation test runner helper #2124

Merged
merged 1 commit into from
Nov 6, 2020
Merged

fix multi-operation test runner helper #2124

merged 1 commit into from
Nov 6, 2020

Conversation

djrtwo
Copy link
Contributor

@djrtwo djrtwo commented Nov 6, 2020 •
edited
Loading

Test gen was rendering the post state for pre and post. Fix order of operations to render properly.

Thanks @ajsutton!

Note, this has already been patched to the test vector release. Plans is to merge into master here. Then backport to dev. Will not cut a new spec release

@djrtwo djrtwo requested a review from protolambda November 6, 2020 16:04
protolambda
protolambda approved these changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find by Adrian 👏

@djrtwo djrtwo merged commit 450c8c2 into master Nov 6, 2020
@djrtwo djrtwo deleted the fix-1.0-tests branch November 6, 2020 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@protolambda protolambda protolambda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djrtwo @protolambda